Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: automated upgrade process RFC #36

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Conversation

piontec
Copy link
Contributor

@piontec piontec commented May 27, 2022

No description provided.

Copy link
Member

@fiunchinho fiunchinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The process described here makes sense. But isn't this already covered on this RFC https://github.com/giantswarm/rfc/tree/main/automatic-app-upgrades ? Quoting

We could set up rules for Flux controllers to update App CRs in a repository whenever a new chart version (matching the automation rule) is pushed to the Azure Container Registry. Then Flux GitOps controllers would see the update in the repository and apply it to the cluster, effectively updating the App CR with the new version. All of this would be triggered automatically after a new release is crafted for any of the apps. The updated App version would be committed to the branch watched by GitOps controllers so that the update happens automatically.

That sounds basically the same. If this RFC is about explicitly mentioning bases and linking to our gitops repositories, wouldn't it be better to update the other RFC?

@gianfranco-l gianfranco-l changed the title add: autoamted upgrade process RFC add: automated upgrade process RFC Jun 3, 2022
@pipo02mix
Copy link
Contributor

yeah @piontec WDYT about integrating with the existing one?

@piontec
Copy link
Contributor Author

piontec commented Jun 13, 2022

Yeah, makes sense, I need to merge them

1. The new App Chart CR is tested for successful [upgrade using `ats`](https://github.com/giantswarm/app-test-suite#quick-start)
1. The App is released, the chart has to be put into OCI repository (already supported by `architect-orb`)
1. GitOps configuration part
1. Customer has prepared GitOps repository, including bases (they don't have to be bases, they can be individual clusters/apps, but we're encouraging bases for better (re)usability) that make sense for grouping their infrastructure (Honeybadger is working on specific layout recommendations)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this structure is really the important thing.

@gianfranco-l
Copy link

@MarcelMue @piontec what is holding us back from merging this PR and close this ticket?

@MarcelMue
Copy link
Contributor

@MarcelMue @piontec what is holding us back from merging this PR and close this ticket?

IMO nothing is stopping this PR to be merged but it only addresses some points from the issue.

@piontec piontec merged commit 84a8876 into main Jul 1, 2022
@piontec piontec deleted the add-gitops-upgrade-process branch July 1, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants