Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster-azure incorrectly uses 1.25.16 version on worker Machine CRs #3670

Closed
AverageMarcus opened this issue Sep 5, 2024 · 0 comments · Fixed by giantswarm/cluster#322
Closed
Assignees
Labels
team/tenet Team Tenet

Comments

@AverageMarcus
Copy link
Member

AverageMarcus commented Sep 5, 2024

Taken from this comment

It looks like cluster-azure still has v1.25.16 hardcoded as the kubernetes version, even when using Releases (see https://github.com/giantswarm/cluster-azure/blob/b596bf76166dd4e4d34fb8dc6b50ccaef60080f5/helm/cluster-azure/values.yaml#L281)

While this isn't used for the VM image (and thus the kubelet version is actually correct) is does mean that the version against the Machine CR on the MC for worker nodes (but not control plane) are displaying the incorrect version.

Example:

Machine CR

┗ ✨ k get machine -n org-t-bt9dnfj4c5ui3866bi
NAME                                          CLUSTER                NODENAME                                            PROVIDERID                                                                                                                                                                                      PHASE          AGE     VERSION
t-t9ndh2m377aj0x23be-8f479                    t-t9ndh2m377aj0x23be   t-t9ndh2m377aj0x23be-control-plane-af713ece-94zp8   azure:///subscriptions/6b1f6e4a-6d0e-4aa4-9a5a-fbaca65a23b3/resourceGroups/t-t9ndh2m377aj0x23be/providers/Microsoft.Compute/virtualMachines/t-t9ndh2m377aj0x23be-control-plane-af713ece-94zp8   Running        6m14s   v1.29.7
t-t9ndh2m377aj0x23be-nodepool-0-fwjgl-f6w57   t-t9ndh2m377aj0x23be   t-t9ndh2m377aj0x23be-nodepool-0-e1b298d1-ztpxj      azure:///subscriptions/6b1f6e4a-6d0e-4aa4-9a5a-fbaca65a23b3/resourceGroups/t-t9ndh2m377aj0x23be/providers/Microsoft.Compute/virtualMachines/t-t9ndh2m377aj0x23be-nodepool-0-e1b298d1-ztpxj      Running        8m27s   v1.25.16
t-t9ndh2m377aj0x23be-nodepool-0-fwjgl-xcxrp   t-t9ndh2m377aj0x23be   t-t9ndh2m377aj0x23be-nodepool-0-e1b298d1-mlxss      azure:///subscriptions/6b1f6e4a-6d0e-4aa4-9a5a-fbaca65a23b3/resourceGroups/t-t9ndh2m377aj0x23be/providers/Microsoft.Compute/virtualMachines/t-t9ndh2m377aj0x23be-nodepool-0-e1b298d1-mlxss      Running        8m27s   v1.25.16
t-t9ndh2m377aj0x23be-vvdr2                    t-t9ndh2m377aj0x23be                                                                                                                                                                                                                                                       Provisioning   45s     v1.29.7

Nodes

┗ ✨ k get no -o wide
NAME                                                STATUS   ROLES                  AGE     VERSION   INTERNAL-IP   EXTERNAL-IP   OS-IMAGE                                             KERNEL-VERSION   CONTAINER-RUNTIME
t-t9ndh2m377aj0x23be-control-plane-af713ece-94zp8   Ready    control-plane,master   5m4s    v1.29.7   10.0.0.4      <none>        Flatcar Container Linux by Kinvolk 3815.2.5 (Oklo)   6.1.96-flatcar   containerd://1.7.13
t-t9ndh2m377aj0x23be-nodepool-0-e1b298d1-mlxss      Ready    worker                 3m37s   v1.29.7   10.0.16.5     <none>        Flatcar Container Linux by Kinvolk 3815.2.5 (Oklo)   6.1.96-flatcar   containerd://1.7.13
t-t9ndh2m377aj0x23be-nodepool-0-e1b298d1-ztpxj      Ready    worker                 3m37s   v1.29.7   10.0.16.4     <none>        Flatcar Container Linux by Kinvolk 3815.2.5 (Oklo)   6.1.96-flatcar   containerd://1.7.13
@AverageMarcus AverageMarcus converted this from a draft issue Sep 5, 2024
@AverageMarcus AverageMarcus added the team/tenet Team Tenet label Sep 5, 2024
@njuettner njuettner self-assigned this Sep 5, 2024
@njuettner njuettner moved this from Inbox 📥 to In Progress ⛏️ in Roadmap Sep 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress ⛏️ to Done ✅ in Roadmap Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/tenet Team Tenet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants