Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support watching specific namespaces #226

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Sep 26, 2022

Checklist

  • Update changelog in CHANGELOG.md.

Proposal

Make it possible to watch only for a specific set of namespaces for Silence CR changes.
Doesn't change the actual behavior of the operator as it remains cluster wide by default.
Breaking change in the CRD to make its scope Namespaced.

@maxime1907 maxime1907 requested a review from a team as a code owner September 26, 2022 16:42
@QuentinBisson
Copy link
Contributor

What's your use case to restrict it to namespace?

@maxime1907
Copy link
Contributor Author

What's your use case to restrict it to namespace?

We have RBAC enforced on our clusters that strictly splits every client in its own namespace managed by a specific team.
So with the current implementation of silence-operator, we cannot let these specific teams manage silences since they only have rights to list resources in their authorized namespaces.

@maxime1907
Copy link
Contributor Author

Any update @QuentinBisson ?

@maxime1907
Copy link
Contributor Author

Any update @hervenicol ?

@hervenicol
Copy link
Contributor

Sorry @maxime1907, end of year was a bit rough.
@QuentinBisson should be the one giving approval. In January hopefully, as he still is rather busy.

@maxime1907
Copy link
Contributor Author

Sorry @maxime1907, end of year was a bit rough. @QuentinBisson should be the one giving approval. In January hopefully, as he still is rather busy.

Okay no problem, thank you for answering!

@maxime1907
Copy link
Contributor Author

Any update/Are you still busy @QuentinBisson ?

@QuentinBisson QuentinBisson mentioned this pull request Jun 12, 2023
1 task
@sebastiangaiser
Copy link

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants