Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .svc suffix to alertmanager address #231

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

bavarianbidi
Copy link
Contributor

@bavarianbidi bavarianbidi commented Oct 11, 2022

To make Silence Operator work behind a corporate proxy, we have to inject the HTTP_PROXY, HTTPS_PROXY and NO_PROXY variable.

To keep the NO_PROXY list as "simple" as possible, following in-cluster-specific values are configured:
<baseDomain>,<podCIDRBlock>,<serviceCIDRBlock>,<external_k8s_API_IP>.

To not change every application to make use of the FQDN (as baseDomain could differ) i've decided to add svc to the NO_PROXY list.

The change of the alertmanager address from alertmanager-operated.monitoring to alertmanager-operated.monitoring.svc should be a no op for all existing clusters.

towards: giantswarm/roadmap#1423
xref: giantswarm/prometheus-meta-operator#1010

Checklist

  • Update changelog in CHANGELOG.md.

@QuentinBisson
Copy link
Contributor

I'll try to test it tomorrow

@bavarianbidi
Copy link
Contributor Author

go 1.19 update + golangci-lint fix: #232

Copy link
Member

@TheoBrigitte TheoBrigitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tested

@bavarianbidi
Copy link
Contributor Author

LGTM when tested

@TheoBrigitte as i didn't worked with the silence-operator so far: how can i test it? what are the test-cases i have to do?

@QuentinBisson QuentinBisson merged commit 2971560 into master Oct 12, 2022
@QuentinBisson QuentinBisson deleted the use_svc_suffix branch October 12, 2022 14:29
@TheoBrigitte
Copy link
Member

The way to test silence-operator is to basically restart alertmanager check the operator logs and making sure the correct silences where created in alertmanager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants