add .svc suffix to alertmanager address #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make Silence Operator work behind a corporate proxy, we have to inject the
HTTP_PROXY
,HTTPS_PROXY
andNO_PROXY
variable.To keep the
NO_PROXY
list as "simple" as possible, following in-cluster-specific values are configured:<baseDomain>,<podCIDRBlock>,<serviceCIDRBlock>,<external_k8s_API_IP>
.To not change every application to make use of the FQDN (as
baseDomain
could differ) i've decided to addsvc
to theNO_PROXY
list.The change of the alertmanager address from
alertmanager-operated.monitoring
toalertmanager-operated.monitoring.svc
should be a no op for all existing clusters.towards: giantswarm/roadmap#1423
xref: giantswarm/prometheus-meta-operator#1010
Checklist