App-operator watching label set false #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssyno
changed the title
anvddriesch
reviewed
Mar 21, 2024
| @@ -65,6 +65,9 @@ func (t *Teleport) CreateConfigMap(ctx context.Context, log logr.Logger, ctrlCli | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: configMapName, | |||
| Namespace: clusterNamespace, | |||
| Labels: map[string]string{ | |||
| "app-operator.giantswarm.io/watching": "false", | |||
There was a problem hiding this comment.
Is it okay to add the label upon creation already?
I'm asking because initially it is needed for the configmap to be used to configure the app. Or does this just mean it won't be watched after the initial configuration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Towards: Issue 30290
app-operator.giantswarm.io/watchingto"false"on configmap created by the operator to avoid the unstopable reconciliation of the resource.Checklist