Address rabbit comments

gibber9809 · Dec 16, 2024 · 1483c35 · 1483c35
1 parent 8508084
commit 1483c35
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/components/core/src/clp_s/Utils.hpp b/components/core/src/clp_s/Utils.hpp
@@ -230,8 +230,8 @@ class StringUtils {
      * (e.g. \n) and less common control sequences with unicode escape sequences (e.g. \u001f). The
      * '"' and '\' characters are escaped with a backslash.
      *
-     * @param source
      * @param destination
+     * @param source
      */
     static void escape_json_string(std::string& destination, std::string_view const source);
 
@@ -245,7 +245,7 @@ class StringUtils {
      *
      * @param value
      * @param unescaped
-     * @return true if the value was escaped succesfully and false otherwise.
+     * @return true if the value was unescaped successfully, false otherwise.
      */
     static bool unescape_kql_value(std::string const& value, std::string& unescaped);
 
@@ -280,7 +280,7 @@ class StringUtils {
             if ('\x00' <= nibble && nibble <= '\x09') {
                 return '0' + (nibble - '\x00');
             } else {
-                return 'a' + (nibble - '\x10');
+                return 'a' + (nibble - '\x0a');
             }
         };
 

diff --git a/components/core/src/clp_s/search/kql/Kql.g4 b/components/core/src/clp_s/search/kql/Kql.g4
@@ -93,6 +93,6 @@ fragment SPECIAL_CHARACTER
 
 // For unicode hex
 fragment UNICODE: '\\u' HEXDIGIT HEXDIGIT HEXDIGIT HEXDIGIT ;
-fragment HEXDIGIT: [0-9a-fA-F]+ ;
+fragment HEXDIGIT: [0-9a-fA-F] ;
 
 SPACE:  [ \t\r\n] -> skip ;