Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Keywords:" from Dataset landing page if there are no keywords #2027

Open
14 tasks
tuli opened this issue Sep 11, 2024 · 3 comments
Open
14 tasks

Remove "Keywords:" from Dataset landing page if there are no keywords #2027

tuli opened this issue Sep 11, 2024 · 3 comments

Comments

@tuli
Copy link

tuli commented Sep 11, 2024

User story

As a website user
I want the word "Keywords" not to be visible if the dataset has no keywords
So that the landing page looks better

Acceptance criteria

Given conditions : a dataset spreadsheet is generated where the keywords column is empty.
When event: the spreadsheet is uploaded to the database by tech
Then outcome: the word "Keywords: " should not be visible on the dataset landing page.

Given a dataset as some keywords attached to it
When I navigate to the dataset form
And I remove all the keywords
Then the word "Keywords: " should not be visible on the dataset landing page.

Additional Info

Product Backlog Item Ready Checklist

  • Business value is clearly articulated
  • Item is understood enough by the IT team so it can make an informed decision as to whether it can complete this item
  • Dependencies are identified and no external dependencies would block this item from being completed
  • At the time of the scheduled sprint, the IT team has the appropriate composition to complete this item
  • This item is estimated and small enough to comfortably be completed in one sprint
  • Acceptance criteria are clear and testable
  • Performance criteria, if any, are defined and testable
  • The Scrum team understands how to demonstrate this item at the sprint review

Product Backlog Item Done Checklist

  • Item(s) in increment pass all Acceptance Criteria
  • Code is refactored to best practices and coding standards
  • Documentation is updated as needed
  • Data security has not been compromised (with particular reference to the personal information we hold in GigaDB)
  • No deviation from the team technology stack and software architecture has been introduced
  • The product is in a releasable state (i.e. the increment has not broken anything)

GigaDBUpload_v19_102572_GIGA-D-23-00276_stereo.xls

Screenshot 2024-09-11 at 11 28 48

@luistoptal
Copy link
Collaborator

@only1chunts is there a way for me to get access to this dataset?

@only1chunts
Copy link
Member

I've just had a look for public datasets that have no keywords and found 102537, and that does NOT show the issue that @tuli raised! I can still see the issue on the Mockup page of the one that Mary Ann found it on, so its a real issue on mock up pages, but its been fixed on the public pages.

@luistoptal
Copy link
Collaborator

@only1chunts it's hard for me to tell what is going on here without looking directly at the database but my guess is that the db contains something like an empty string or maybe a space, this would display the keywords title in screen like in the mockup. My PR fixes that. Can you tell me if this dataset has something like an empty space in the keywords field in the DB, to verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants