Filter empty keywords from keywords list on dataset view #2057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2027
This is a pull request for the following functionalities:
this is based on guessing what the issue might be with the dataset shown in the issue as I do not have access to it in the test site
How to test?
I don't know of a test dataset which has the same issue indicated in the ticket, if the guess is correct, ie empty string keyword, you might go to protected/views/dataset/view.php line 97 and replace the
protected/views/dataset/view.php
with['', ' ', ' ']
and check for any dataset whether "keyword" is displayed under the descriptionHow have functionalities been implemented?
note: if the diagnostic is correct, then it would be also advisable to disallow empty keywords client side to begin with from wherever the user inputs them, or / and filter them out server side
Any issues with implementation?
I do not know how to access the dataset in the ticket to better check this