Filter empty keywords from keywords list on dataset view

CHANGELOG.md

@@ -4,6 +4,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
+- Feat #2027: Filter empty keywords from keywords list on dataset view
 - Feat #456: Improve DataCite metadata by migrating to Datacite version 4.6
 - Fix #1727: Sort files and samples by id in descending order when querying
 

protected/components/StoredDatasetMainSection.php

@@ -145,7 +145,11 @@ public function getKeywords(): array
         $flatten = function ($row) {
             return $row['value'];
         };
-        return array_map($flatten, $result);
+        $keywords = array_map($flatten, $result);
+        $filteredKeywords = array_filter($keywords, function ($keyword) {
+            return !empty(trim($keyword));
+        });
+        return $filteredKeywords;
     }
 
     /**

protected/views/dataset/view.php

@@ -92,10 +92,15 @@ function showText() {
             </div>
 
             <div class="subsection">
-                <?php if (!empty($mainSection->getKeywords())) { ?>
+                <?php
+                $validKeywords = array_filter(
+                  $mainSection->getKeywords(), function($keyword) {
+                    return strlen(trim($keyword)) > 0;
+                });
+                if (!empty($validKeywords)) { ?>
                     <p>Keywords:</p>
                     <ul class="list-inline">
-                        <? foreach ($mainSection->getKeywords() as $keyword_link) {
+                        <? foreach ($validKeywords as $keyword_link) {
                             echo "<li>$keyword_link</li>";
                         }
                         ?>

tests/_support/Steps/CuratorSteps.php

@@ -159,6 +159,18 @@ public function iFillInKeywordsFieldsWith($keyword)
         $this->I->waitForText($keyword, 5, ".tag-editor-tag");
     }
 
+    /**
+     * @When I remove all the keywords
+     */
+    public function iRemoveAllKeywords()
+    {
+        $deleteButtons = $this->I->grabMultiple('.tag-editor .tag-editor-delete');
+        foreach ($deleteButtons as $button) {
+            $this->I->click('.tag-editor .tag-editor-delete');
+            $this->I->wait(1);
+        }
+    }
+
     /**
      * @Then I should see the application version
      */

tests/acceptance/AdminDatasetForm.feature

@@ -496,3 +496,11 @@ Feature: form to update dataset details
     And I press the button "Next >"
     And I wait "1" seconds
     Then I should see "Parrot.k31.NetworkTest.txt"
+
+  @ok @issue-2027
+  Scenario: Keywords label not visible if keywords are removed from dataset
+    Given I am on "/adminDataset/update/id/200"
+    And I remove all the keywords
+    And I press the button "Save"
+    When I am on "/dataset/100142"
+    Then I should not see "Keywords:"