Sort dataset files by size

[luistoptal]

Pull request for issue: #2067

• sort header sorts files by size rather than a-z in dataset view pages, eg http://gigadb.gigasciencejournal.com/dataset/100035

How to test?

• navigate to http://gigadb.gigasciencejournal.com/dataset/100035
• click on size header
• check that rows are sorted by actual size not a-z

How have functionalities been implemented?

customized the sorting function for the size column

Any issues with implementation?

--

Any changes to automated tests?

--

[rija]

Hi @luistoptal,
anything preventing you to make this PR ready, I think it's embarassing issues that bothers curators a lot.

[luistoptal]

Hi @rija

Nothing is preventing, there are about 18 pending PRs, I keep ready for review only a few at a time and set for review more of them as the existing ones are merged

I will rebase this one and make ready

[kencho51]

Hi @luistoptal,

praise: The sorting based on size is working on my dev
issue: There should be acceptance for it
suggestion: Maybe the acceptance test could be as the followings:

Scenario: Files tab can be sort by size in ascending order
    Given I have not signed in
    And I am on "/dataset/100035"
    And I follow "Files"
    And I follow "1"
    And I should see ""
    When I click "Size"
    Then I should see ""

  Scenario: Files tab can be sort by size in descending order
    Given I have not signed in
    And I am on "/dataset/100035"
    And I follow "Files"
    And I follow "1"
    And I should see ""
    When I click "Size"
    And I click "size"
    Then I should see ""

[rija]

Hi @luistoptal,

praise: functionality works locally and on my AWS deployment
praise: great that they are additional test scenarios that cover the functionality, with one of them capable of surfacing the bug raised in the associated issue
praise: all tests are passing locally and on CI

Based on that, I'm happy to approve this PR

[kencho51]

Hi @luistoptal,

praise: The acceptance tests are created and passing.

Based on the above and given the PR conflict is fixed, happy to approve.