Feat 2117 rewritting the api endpoint returning dataset as xml #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2117
This is a pull request for the following functionalities:
will need #1978 and #2118 merged
Rewriting the API endpoint that returns the Dataset in XML format
No need for the four different templates.
Everything could be handled via a single Yii2 service.
The parameters and the way the API is called should remain the same as before.
How to test?
Given I follow the instructions on the API help page (https://gigadb.org/site/help#interface)
When I select the example as shown "http://gigadb.org/api/dataset?doi=100051"
Then I see the correct results
How have functionalities been implemented?
Any issues with implementation?
Any changes to automated tests?
tests added
Any changes to documentation?
Any technical debt repayment?
Any improvements to CI/CD pipeline?