-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin forms layout fills screen width using well wrapper #2168
Draft
luistoptal
wants to merge
16
commits into
gigascience:develop
Choose a base branch
from
luistoptal:new-feature/2100-well-style-admin-forms
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Admin forms layout fills screen width using well wrapper #2168
luistoptal
wants to merge
16
commits into
gigascience:develop
from
luistoptal:new-feature/2100-well-style-admin-forms
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age-on-admin-pages
…age-on-admin-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2100
Review PR #2108 as this is an extension
What this PR does is update all the admin forms to use the well layout instead, since we agree in issue #2100 that it looks better
I.e.
I have created this as a separate PR because previously I converted all the froms to the unwrapped layout type. So having this as a separate PR keeps the choice of using either in the final version essentially for free
If we decide for the unwrapped layout, simply merge the PR #2108, otherwise merge this PR