Fix 1955 edit user #2191
Open
Fix 1955 edit user #2191
+200
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imho, the separate model for changing one's own password is not required. I kept it because the goal here is to fix the bug but I believe it can be rewritten |
14 tasks
|
@alli83 can you add which GitHub issue (issue number to they can be linked automatically) this PR is for, thanks. |
kencho51
reviewed
Feb 20, 2025
|
|
||
| if ($user->save(false)) { | ||
|
|
||
| Yii::app()->user->setFlash('notice', 'Updated'); | ||
| $this->redirect(array('user/show/id/'.$user->id)); |
There was a problem hiding this comment.
Hi @alli83,
issue: When the form is updated, the page will be redirected to a broken page like this:
suggestion: Would it be better to redirect page to the view page as below:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #1955
This is a pull request for the following functionalities:
add a regex for password
password is optional when I want to edit an user
captcha not required for update
How to test?
Given I am on the user admin form for a user
When I change its details
And I click Save
Then the details is saved to the database
And I am not asked to fill a captcha
Given I am on the user admin form for a user
When I change its details
And I click Save
Then the details is saved to the database
And I am not forced to provide a password for that user
How have functionalities been implemented?
Any issues with implementation?
Any changes to automated tests?
test added
Any changes to documentation?
Any technical debt repayment?
Any improvements to CI/CD pipeline?