Update default dataset view file settings #2218
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2122
This is a pull request for the following functionalities:
How to test?
If you go to any dataset page and open the file settings modal, the default option should be 50. However, the way the protected/components/DatasetPageSettings.php is configured, it used different default settings for live and dev, as can be seen in
protected/controllers/DatasetController.php:73
, so it is probably sufficient to confirm that the default for live is set correctlyHow have functionalities been implemented?
public function getFileSettings
Any issues with implementation?
Since dev uses a different default, the acceptance test added to check the expected defaults will not pass and so I tagged it as broken and added an explanation
Any changes to automated tests?
See above