Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default dataset view file settings #2218

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

luistoptal
Copy link
Collaborator

Pull request for issue: #2122

This is a pull request for the following functionalities:

  • Update default active columns for file table in dataset page, according to the ticket description
  • Update default number of items per page to 50

How to test?

If you go to any dataset page and open the file settings modal, the default option should be 50. However, the way the protected/components/DatasetPageSettings.php is configured, it used different default settings for live and dev, as can be seen in protected/controllers/DatasetController.php:73, so it is probably sufficient to confirm that the default for live is set correctly

const VIEW_DEFAULT_FILE_COLUMNS = ['name', 'description', 'format_id', 'size', 'location'];

How have functionalities been implemented?

  • updated VIEW_DEFAULT_FILE_COLUMNS array
  • Updated default items per page in public function getFileSettings
  • Added acceptance tests to check the expected defaults

Any issues with implementation?

Since dev uses a different default, the acceptance test added to check the expected defaults will not pass and so I tagged it as broken and added an explanation

Any changes to automated tests?

See above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant