Add top offset up to the body

[sergei-deriv]

Issue: when the next step is out of the screen viewport tooltip is in the wrong place.

How it was before:

How it looks now:

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80c4752:

Sandbox	Source
React	Configuration

[gilbarbara]

Hey @sergei-deriv
Before considering this PR, I need to see this behavior happening to ensure it can't be fixed with CSS alone.
Can you create a codesandbox with a minimal reproducible example?

[sergei-deriv]

Hey @sergei-deriv Before considering this PR, I need to see this behavior happening to ensure it can't be fixed with CSS alone. Can you create a codesandbox with a minimal reproducible example?

Thank you for your fast reply, really appreciate it. You can see the error on your own site in tab scroll (https://react-joyride.com/scroll). I'll try to record the video when sometimes your library highlights wrong elements for scrolling parents when element is outside of viewport

Wrong.place.mov

[gilbarbara]

@sergei-deriv I'm still getting the same behavior with your changes.

react-joyride-scroll.mp4

By the way, I didn't test the dom utilities on purpose. Using JSDOM to test element size and offset increases the coverage, but it's completely fake. :)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[Barash777]

@sergei-deriv I'm still getting the same behavior with your changes.

react-joyride-scroll.mp4
By the way, I didn't test the dom utilities on purpose. Using JSDOM to test element size and offset increases the coverage, but it's completely fake. :)

Hi @gilbarbara. I thought PR didn't pass the validation because of coverage decrease and by this reason I've added tests :) About the same behaviour, it's strange and in this case what exactly I've fixed and why it works for my case)) Please, don't close the PR, I'll try to find a solution for this case too and add changes here. Thanks

[gilbarbara]

Fixed in 2.7.2
Thanks