Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expiry time issue for certification #56

Open
thedavidmeister opened this issue May 20, 2024 · 3 comments · May be fixed by #63
Open

expiry time issue for certification #56

thedavidmeister opened this issue May 20, 2024 · 3 comments · May be fixed by #63
Assignees
Labels
bug Something isn't working

Comments

@thedavidmeister
Copy link
Collaborator

No description provided.

@thedavidmeister thedavidmeister added the bug Something isn't working label May 20, 2024
@ninokeldishvili
Copy link
Collaborator

The issue is getting futureReferenceBlock error while trying to perform certification.

We have encountered an error related to the certification process specifically on the Arbitrum Sepolia network. Contract was deployed on several other test networks and this issue does not occur on any of the other networks but Arbitrum Sepolia

@ninokeldishvili ninokeldishvili linked a pull request May 20, 2024 that will close this issue
@ninokeldishvili
Copy link
Collaborator

I was having issue with certify test for the OffchainAssetReceiptVault. Error looked like this

[89287] OffChainAssetReceiptVaultTest::test_Certify() ├─ [74143] OffchainAssetReceiptVaultFactory::createChildTyped(ERC20PriceOracleVaultConfig({ priceOracle: 0x1804c8AB1F12E6bbf3894d4083f33e07309d1f38, vaultConfig: VaultConfig({ asset: 0x0000000000000000000000000000000000000000, name: "Asset Name", symbol: "ASSET" }) })) │ ├─ [9031] → new <unknown>@0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2 │ │ └─ ← [Return] 45 bytes of code │ ├─ [250] ReceiptVault::createChild(0x) │ │ └─ ← [Revert] EvmError: Revert │ └─ ← [Revert] EvmError: Revert └─ ← [Revert] EvmError: Revert
I managed to fix this error.
wrote tests to check :

Certify

RevertOnZeroCertifyUntil

RevertOnFutureReferenceBlock

@ninokeldishvili ninokeldishvili removed a link to a pull request May 21, 2024
@ninokeldishvili ninokeldishvili linked a pull request May 21, 2024 that will close this issue
@ninokeldishvili
Copy link
Collaborator

Script for failing certification on Arbitrum Sepolia has been added
env variable should be added before running the script for factory contract address.
on arbitrum sepolia it would be:
CONTRACT_FACTORY_ADDRESS=0xf1A14e96977E8dE295Ba9612691D127B157d1371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants