Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

56 expiry time issue for certification #63

Closed
wants to merge 19 commits into from

Conversation

ninokeldishvili
Copy link
Collaborator

No description provided.

@ninokeldishvili ninokeldishvili linked an issue May 21, 2024 that may be closed by this pull request
@Siddharth2207
Copy link
Contributor

Siddharth2207 commented Sep 16, 2024

  • From my debugging session, for arbitrum sepolia network, the issue isn't expiry time, but the transaction reverts with FutureReferenceBlock error .
  • I tried to reproduce the revert transaction in foundry fork environment, replaying it with the same calldata that I received from the webapp, and the transaction succeed. So as far as I can tell there is no issue with the contract.
  • Here is the calldata I replayed at block number 81155171.
{
data: "0x86eb6bb80000000000000000000000000000000000000000000000000000000066f84b270000000000000000000000000000000000000000000000000000000004d654630000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000000140000000000000000000000000000000000000000000000000000000000000000"
from: "0x669845c29D9B1A64FFF66a55aA13EB4adB889a88"
to: "0xadd2dbd7f89c7521b7c88d406d2e74ea3091d927"
}

where to address is the OffchainAssetReceiptVault instance.

@ninokeldishvili ninokeldishvili linked an issue Nov 1, 2024 that may be closed by this pull request
@ninokeldishvili ninokeldishvili self-assigned this Nov 5, 2024
@thedavidmeister
Copy link
Collaborator

i'm going to close this because the expiry time doesn't fail locally, as @ninokeldishvili and @Siddharth2207 pointed out

it's likely due to using the incorrect block times from the RPC for L2

https://docs.arbitrum.io/build-decentralized-apps/arbitrum-vs-ethereum/block-numbers-and-time#block-numbers-arbitrum-vs-ethereum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pr to use foundry expiry time issue for certification
3 participants