Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python-kasa library usage so every command works #35

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

tommoyer
Copy link
Contributor

@tommoyer tommoyer commented Oct 6, 2024

Based on the documentation from the python-kasa library, we must create a new SmartPlug object for each async function instead of reusing the same SmartPlug object in each function

Based on the documentation from the python-kasa library, we must
create a new SmartPlug object for each async function instead of
reusing the same SmartPlug object in each function
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (931fe48) to head (d23c0ce).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/maaspower/devices/kasa_device.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   69.18%   64.57%   -4.62%     
==========================================
  Files          10       12       +2     
  Lines         370      463      +93     
==========================================
+ Hits          256      299      +43     
- Misses        114      164      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gilesknap
Copy link
Owner

Thanks for this! There are a couple of minor errors in the CI.

You can run CI locally using tox -p after doing a pip install -e .'[]dev'

@gilesknap
Copy link
Owner

nice! merging.

@gilesknap gilesknap merged commit f298d50 into gilesknap:main Oct 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants