Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simple example + fixed warning in ast.rs #294

Merged
merged 4 commits into from
May 25, 2024
Merged

Conversation

Cr0a3
Copy link
Contributor

@Cr0a3 Cr0a3 commented May 10, 2024

Hi,
I added a simple example (examples/simple.rs) which is just the readme example.
I also fixed the unused warning in src/ast.rs:359 by adding #[allow(unused)]
Bye

@Cr0a3
Copy link
Contributor Author

Cr0a3 commented May 16, 2024

@fitzgen

@khuey
Copy link
Collaborator

khuey commented May 21, 2024

Thanks for the PR. As CI shows, this example needs to be disabled for the no_std build.

@khuey
Copy link
Collaborator

khuey commented May 23, 2024

That's not sufficient. You need something like this in Cargo.toml

[[example]]
name = "simple"
path = "examples/simple.rs"
required-features = ["std"]

@Cr0a3
Copy link
Contributor Author

Cr0a3 commented May 24, 2024

I fixed it

@khuey khuey merged commit ef3cb9f into gimli-rs:master May 25, 2024
5 checks passed
@khuey
Copy link
Collaborator

khuey commented May 25, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants