Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: concurrent map writes (#15) #69

Closed

Conversation

zhyee
Copy link
Contributor

@zhyee zhyee commented Aug 29, 2024

  • It may lead to a concurrent map writes fatal error after the deadline reached.

 - fatal error: concurrent map writes(gin-contrib#15)
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.28%. Comparing base (1d781d2) to head (5a92f27).
Report is 15 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   95.27%   94.28%   -0.99%     
==========================================
  Files           4        4              
  Lines         127      105      -22     
==========================================
- Hits          121       99      -22     
  Misses          4        4              
  Partials        2        2              
Flag Coverage Δ
go-1.18 ?
go-1.20 94.28% <100.00%> (?)
go-1.21 90.47% <100.00%> (-4.80%) ⬇️
go-1.22 92.38% <100.00%> (?)
ubuntu-latest 94.28% <100.00%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhyee
Copy link
Contributor Author

zhyee commented Aug 29, 2024

Fix #15

@demouth
Copy link
Contributor

demouth commented Aug 29, 2024

It seems like a good idea, but I think it's the same fix as #55.

@appleboy
Copy link
Member

duplicated of #55

@appleboy appleboy closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants