Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL path value still unescaped when UnescapePathValues set false #4036

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix URL path value still unescaped when UnescapePathValues set false #4036

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf6728e
fix: fix URL path value still unescaped when UnescapePathValues set f…
Aug 20, 2024
6c7a318
fix: fix URL path value still unescaped when UnescapePathValues set f…
Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ func (engine *Engine) HandleContext(c *Context) {

func (engine *Engine) handleHTTPRequest(c *Context) {
httpMethod := c.Request.Method
rPath := c.Request.URL.Path
rPath := c.Request.URL.EscapedPath()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed right?
Now we are always routing based on the EscapedPath which changes the default behaviour

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed right? Now we are always routing based on the EscapedPath which changes the default behaviour

You are right.

unescape := false
if engine.UseRawPath && len(c.Request.URL.RawPath) > 0 {
rPath = c.Request.URL.RawPath
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rPath := c.Request.URL.EscapedPath()
unescape := false
if engine.UseRawPath && len(c.Request.URL.RawPath) > 0 {
rPath = c.Request.URL.RawPath
rPath := c.Request.URL.Path
unescape := false
if engine.UseRawPath {
rPath = c.Request.URL.EscapedPath()

Expand Down
2 changes: 1 addition & 1 deletion logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func LoggerWithConfig(conf LoggerConfig) HandlerFunc {
return func(c *Context) {
// Start timer
start := time.Now()
path := c.Request.URL.Path
path := c.Request.URL.EscapedPath()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

using Path it seem something wrong in this case.

raw := c.Request.URL.RawQuery

// Process request
Expand Down