Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed Value do not respect the context.WithValue contract #4075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed Value do not respect the context.WithValue contract #4075

wants to merge 1 commit into from

Conversation

huangjilaiqin
Copy link

fixed Value func do not respect the context.WithValue contract #4074

@huangjilaiqin huangjilaiqin reopened this Oct 14, 2024
@huangjilaiqin
Copy link
Author

@appleboy look at this please

@FarmerChillax
Copy link
Contributor

FarmerChillax commented Oct 15, 2024 •
edited
Loading

This is not the root cause of the current problem, because the types are not consistent.

test case: https://go.dev/play/p/3PT-KEnVL1e

You should pay attention to hasRequestContext method, looking forward to solving this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huangjilaiqin @FarmerChillax