fix(GiniBankSDK): Define a constant instead of duplicating custom-api…

….domain.com" and "custom-user.domain.com" PP-194
gini · Jan 8, 2025 · 0811c93 · 0811c93
1 parent 0831825
commit 0811c93
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/BankSDK/GiniBankSDKExample/Tests/UnitTests/APILibraryTests/BankAPILibraryTests.swift b/BankSDK/GiniBankSDKExample/Tests/UnitTests/APILibraryTests/BankAPILibraryTests.swift
@@ -10,56 +10,59 @@ import XCTest
 final class BankAPILibraryTests: XCTestCase {
 
     private let client = Client(id: "", secret: "", domain: "")
+    private let customDomain = "custom-api.domain.com"
+    private let cutomUserDomain = "custom-user.domain.com"
 
     func testBuildWithCustomApiDomain() {
-        let api = APIDomain.custom(domain: "custom-api.domain.com", tokenSource: nil)
+        let api = APIDomain.custom(domain: customDomain, tokenSource: nil)
         let giniBankAPILib = GiniBankAPI.Builder(client: client,
                                                  api: api,
                                                  logLevel: .none)
             .build()
 
         let documentService = giniBankAPILib.documentService() as DefaultDocumentService
-        XCTAssertEqual(documentService.apiDomain.domainString, "custom-api.domain.com")
+        XCTAssertEqual(documentService.apiDomain.domainString, customDomain)
     }
 
     func testBuildWithCustomUserDomain() {
-        let userApi = UserDomain.custom(domain: "custom-user.domain.com")
+        let userApi = UserDomain.custom(domain: customDomain)
         let giniBankAPILib = GiniBankAPI.Builder(client: client,
                                                  userApi: userApi,
                                                  logLevel: .none)
             .build()
 
         let documentService = giniBankAPILib.documentService() as DefaultDocumentService
         let sessionManager = documentService.sessionManager as! SessionManager
-        XCTAssertEqual(sessionManager.userDomain.domainString, "custom-user.domain.com")
+        XCTAssertEqual(sessionManager.userDomain.domainString, cutomUserDomain)
     }
 
     func testBuildWithCustomApiAndUserDomain() {
-        let api = APIDomain.custom(domain: "custom-api.domain.com", tokenSource: nil)
-        let userApi = UserDomain.custom(domain: "custom-user.domain.com")
+        let api = APIDomain.custom(domain: customDomain, tokenSource: nil)
+        let userApi = UserDomain.custom(domain: cutomUserDomain)
         let giniBankAPILib = GiniBankAPI.Builder(client: client,
                                                  api: api,
                                                  userApi: userApi,
                                                  logLevel: .none)
             .build()
 
         let documentService = giniBankAPILib.documentService() as DefaultDocumentService
-        XCTAssertEqual(documentService.apiDomain.domainString, "custom-api.domain.com")
+        XCTAssertEqual(documentService.apiDomain.domainString, customDomain)
 
         let sessionManager = documentService.sessionManager as! SessionManager
-        XCTAssertEqual(sessionManager.userDomain.domainString, "custom-user.domain.com")
+        XCTAssertEqual(sessionManager.userDomain.domainString, cutomUserDomain)
     }
 
     func testWithCustomApiDomainAndAlternativeTokenSource() {
         let tokenSource = TokenSource()
-        let apiWithTokenSource = APIDomain.custom(domain: "custom-api.domain.com", tokenSource: tokenSource)
+        let apiWithTokenSource = APIDomain.custom(domain: customDomain, 
+                                                  tokenSource: tokenSource)
         let giniBankAPILib = GiniBankAPI.Builder(client: client,
                                                  api: apiWithTokenSource,
                                                  logLevel: .none)
             .build()
 
         let documentService = giniBankAPILib.documentService() as DefaultDocumentService
-        XCTAssertEqual(documentService.apiDomain.domainString, "custom-api.domain.com")
+        XCTAssertEqual(documentService.apiDomain.domainString, customDomain)
 
         let sessionManager = documentService.sessionManager as! SessionManager
         XCTAssertNotNil(sessionManager.alternativeTokenSource)