Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 981 lint #778

Merged
merged 2 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ protocol EditLineItemViewModelDelegate: AnyObject {
final class EditLineItemViewModel {
weak var delegate: EditLineItemViewModelDelegate?
private var lineItem: DigitalInvoice.LineItem
private (set) var itemsChanged: [GiniLineItemAnalytics] = []
private(set) var itemsChanged: [GiniLineItemAnalytics] = []

var name: String? {
return lineItem.name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ final class SkontoDocumentPagesViewModel: DocumentPagesViewModelProtocol {
private var expiryDate: Date

// Information to be displayed in the screen after highlighting Skonto details
private (set) var processedImages = [UIImage]()
private(set) var processedImages = [UIImage]()
static var screenTitle = NSLocalizedStringPreferredGiniBankFormat("ginibank.skonto.document.pages.screen.title",
comment: "Skonto discount details")
var bottomInfoItems: [String] {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,21 @@ class SkontoViewModel {
var proceedAction: (() -> Void)?

private let skontoDiscounts: SkontoDiscounts
private (set) var isWithDiscountSwitchAvailable: Bool
private(set) var isWithDiscountSwitchAvailable: Bool
private var skontoPercentage: Double

private (set) var isSkontoApplied: Bool = true
private (set) var amountToPay: Price
private (set) var skontoAmountToPay: Price
private(set) var isSkontoApplied: Bool = true
private(set) var amountToPay: Price
private(set) var skontoAmountToPay: Price

private (set) var dueDate: Date
private (set) var amountDiscounted: Price
private (set) var currencyCode: String
private (set) var remainingDays: Int
private (set) var paymentMethod: SkontoDiscountDetails.PaymentMethod
private (set) var edgeCase: SkontoEdgeCase?
private(set) var dueDate: Date
private(set) var amountDiscounted: Price
private(set) var currencyCode: String
private(set) var remainingDays: Int
private(set) var paymentMethod: SkontoDiscountDetails.PaymentMethod
private(set) var edgeCase: SkontoEdgeCase?

private (set) var documentPagesViewModel: SkontoDocumentPagesViewModel?
private(set) var documentPagesViewModel: SkontoDocumentPagesViewModel?

private var maximumAmountToPayValue: Decimal = 99999.99

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class TransactionDocsItemView: UIView {

private let configuration = GiniBankConfiguration.shared

private (set) var transactionDocsItem: TransactionDoc?
private(set) var transactionDocsItem: TransactionDoc?

var optionsAction: (() -> Void)?

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ final class HelpFormatsViewController: UIViewController, HelpBottomBarEnabledVie
tableView.translatesAutoresizingMaskIntoConstraints = false
return tableView
}()
private (set) var dataSource: HelpFormatsDataSource
private(set) var dataSource: HelpFormatsDataSource
private var giniConfiguration: GiniConfiguration
private let tableRowHeight: CGFloat = 44
private let sectionHeight: CGFloat = 70
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ protocol HelpMenuViewControllerDelegate: AnyObject {
final class HelpMenuViewController: UIViewController, HelpBottomBarEnabledViewController {

weak var delegate: HelpMenuViewControllerDelegate?
private (set) var dataSource: HelpMenuDataSource
private(set) var dataSource: HelpMenuDataSource
private let giniConfiguration: GiniConfiguration
private let tableRowHeight: CGFloat = 44
var navigationBarBottomAdapter: HelpBottomNavigationBarAdapter?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ final class HelpTipsViewController: UIViewController, HelpBottomBarEnabledViewCo
tableView.translatesAutoresizingMaskIntoConstraints = false
return tableView
}()
private (set) var dataSource: HelpTipsDataSource
private(set) var dataSource: HelpTipsDataSource
private var giniConfiguration: GiniConfiguration
private let tableRowHeight: CGFloat = 76

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ final class BottomButtonsViewModel {

init(retakeBlock: (() -> Void)? = nil,
manuallyPressed: (() -> Void)? = nil,
cancelPressed: @escaping(() -> Void)) {
cancelPressed: @escaping (() -> Void)) {
self.retakePressed = retakeBlock
self.enterManuallyPressed = manuallyPressed
self.cancelPressed = cancelPressed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ final class NoResultScreenViewController: UIViewController {
}
fatalError("No result header not found")
}()
private (set) var dataSource: HelpDataSource
private(set) var dataSource: HelpDataSource
private var giniConfiguration: GiniConfiguration
private let type: NoResultType
private let viewModel: BottomButtonsViewModel
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ class OnboardingDataSource: NSObject, BaseCollectionViewDataSource {

weak var delegate: OnboardingScreen?
var isProgrammaticScroll = false

private let giniConfiguration: GiniConfiguration
private (set) var currentPageIndex = 0
private(set) var currentPageIndex = 0
private var isInitialScroll = true

lazy var pageModels: [OnboardingPageModel] = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class OnboardingViewController: UIViewController {
@IBOutlet weak var pagesCollection: UICollectionView!
@IBOutlet weak var pageControl: UIPageControl!
@IBOutlet weak var nextButton: MultilineTitleButton!
private (set) var dataSource: OnboardingDataSource
private(set) var dataSource: OnboardingDataSource
private let configuration = GiniConfiguration.shared
private var navigationBarBottomAdapter: OnboardingNavigationBarBottomAdapter?
private var bottomNavigationBar: UIView?
Expand Down