Improve IBAN recognition on device #782
Conversation
| number = number.replacingOccurrences(of: ",", with: "") | ||
| number = number.replacingOccurrences(of: ".", with: "") | ||
| matches = extractIBANMatches(from: String(string.prefix(2)) + number) | ||
| } |
There was a problem hiding this comment.
Hi @igor-gini , Everything looks good to me, just a small suggestion,
We observed in android that sometimes
8 is recognized as B,
7 is recognized as Z,
I think it would be good if you can add these cases as well, If you did not saw any pattern like this in IOS then it is fine as well.
Just for your information here is the android PR link if you want to have a look :)
gini/gini-mobile-android#645
There was a problem hiding this comment.
Hi @igor-gini, Everything looks good, I have added a small suggestion, If you think it will not add any value according to your library, please let me know I will approve the PR. Thank you :)
igor-gini
force-pushed
the
PP-106-Improve-IBAN-recognition-on-device
branch
from
5bdfece to
3d64b82
Compare
|
PP-106