Review updates

Co-authored-by: Yu-Hsiang Tsai <[email protected]>
ginkgo-project · Dec 8, 2023 · 60645ec · 60645ec
1 parent 70161d5
commit 60645ec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/dpcpp/matrix/batch_csr_kernels.hpp.inc b/dpcpp/matrix/batch_csr_kernels.hpp.inc
@@ -37,8 +37,8 @@ __dpct_inline__ void advanced_apply_kernel(
         auto temp = zero<ValueType>();
         for (auto nnz = mat.row_ptrs[row]; nnz < mat.row_ptrs[row + 1]; nnz++) {
             const auto col_idx = col[nnz];
-            temp += alpha * val[nnz] * b[col_idx];
+            temp += val[nnz] * b[col_idx];
         }
-        x[row] = temp + beta * x[row];
+        x[row] = alpha * temp + beta * x[row];
     }
 }
diff --git a/reference/test/matrix/batch_csr_kernels.cpp b/reference/test/matrix/batch_csr_kernels.cpp
@@ -37,13 +37,13 @@ class Csr : public ::testing::Test {
     Csr()
         : exec(gko::ReferenceExecutor::create()),
           mtx_0(gko::batch::initialize<BMtx>(
-              {{I<T>({1.0, -1.0, 1.5}), I<T>({-2.0, 2.0, 3.0})},
-               {{1.0, -2.0, -0.5}, {1.0, -2.5, 4.0}}},
-              exec, 6)),
+              {{I<T>({1.0, -1.0, 0.0}), I<T>({-2.0, 2.0, 3.0})},
+               {{1.0, -2.0, 0.0}, {1.0, -2.5, 4.0}}},
+              exec, 5)),
           mtx_00(gko::initialize<CsrMtx>(
-              {I<T>({1.0, -1.0, 1.5}), I<T>({-2.0, 2.0, 3.0})}, exec)),
+              {I<T>({1.0, -1.0, 0.0}), I<T>({-2.0, 2.0, 3.0})}, exec)),
           mtx_01(gko::initialize<CsrMtx>(
-              {I<T>({1.0, -2.0, -0.5}), I<T>({1.0, -2.5, 4.0})}, exec)),
+              {I<T>({1.0, -2.0, 0.0}), I<T>({1.0, -2.5, 4.0})}, exec)),
           b_0(gko::batch::initialize<BMVec>(
               {{I<T>({1.0, 0.0, 1.0}), I<T>({2.0, 0.0, 1.0}),
                 I<T>({1.0, 0.0, 2.0})},
@@ -82,7 +82,6 @@ class Csr : public ::testing::Test {
     std::ranlux48 rand_engine;
 };
 
-
 TYPED_TEST_SUITE(Csr, gko::test::ValueTypes, TypenameNameGenerator);