try object library disable export

ginkgo-project · May 29, 2024 · 8c53d45 · 8c53d45
1 parent 0ea87bf
commit 8c53d45
Showing 1 changed file with 24 additions and 20 deletions.
diff --git a/core/CMakeLists.txt b/core/CMakeLists.txt
@@ -1,13 +1,17 @@
 add_subdirectory(device_hooks) # placeholders for disabled modules
-
-add_library(ginkgo "")
-set(config_source 
+add_library(config_source OBJECT 
     config/factorization_config.cpp
     config/preconditioner_config.cpp
     config/multigrid_config.cpp
     config/solver_config.cpp
-    config/stop_config.cpp
-)
+    config/stop_config.cpp)
+ginkgo_compile_features(config_source)
+ginkgo_default_includes(config_source)
+set_target_properties(config_source PROPERTIES POSITION_INDEPENDENT_CODE ON)
+set_target_properties(config_source PROPERTIES WINDOWS_EXPORT_ALL_SYMBOLS OFF)
+
+add_library(ginkgo $<TARGET_OBJECTS:config_source> "")
+
 target_sources(ginkgo
     PRIVATE
     base/array.cpp
@@ -127,18 +131,18 @@ if(GINKGO_BUILD_MPI)
         distributed/preconditioner/schwarz.cpp)
 endif()
 
-if(MSVC AND BUILD_SHARED_LIBS)
-    add_library(ginkgo_config "")
-    target_sources(ginkgo_config PRIVATE ${config_source})
-    ginkgo_compile_features(ginkgo_config)
-    ginkgo_default_includes(ginkgo_config)
-    ginkgo_install_library(ginkgo_config)
-    if(GINKGO_CHECK_CIRCULAR_DEPS)
-        ginkgo_check_headers(ginkgo_config "")
-    endif()
-else() 
-    target_sources(ginkgo PRIVATE ${config_source})
-endif()
+# if(MSVC AND BUILD_SHARED_LIBS)
+#     add_library(ginkgo_config "")
+#     target_sources(ginkgo_config PRIVATE ${config_source})
+#     ginkgo_compile_features(ginkgo_config)
+#     ginkgo_default_includes(ginkgo_config)
+#     ginkgo_install_library(ginkgo_config)
+#     if(GINKGO_CHECK_CIRCULAR_DEPS)
+#         ginkgo_check_headers(ginkgo_config "")
+#     endif()
+# else() 
+#     target_sources(ginkgo PRIVATE ${config_source})
+# endif()
 
 ginkgo_compile_features(ginkgo)
 
@@ -147,9 +151,9 @@ ginkgo_compile_features(ginkgo)
 add_library(Ginkgo::ginkgo ALIAS ginkgo)
 target_link_libraries(ginkgo
     PUBLIC ginkgo_device ginkgo_omp ginkgo_cuda ginkgo_reference ginkgo_hip ginkgo_dpcpp)
-if(MSVC AND BUILD_SHARED_LIBS)
-    target_link_libraries(ginkgo_config PUBLIC ginkgo)
-endif()
+# if(MSVC AND BUILD_SHARED_LIBS)
+#     target_link_libraries(ginkgo_config PUBLIC ginkgo)
+# endif()
 if(GINKGO_HAVE_PAPI_SDE)
     target_link_libraries(ginkgo PUBLIC PAPI::PAPI_SDE)
 endif()