review updates:

- use correct identity value - remove incorrect comments Co-authored-by: Tobias Ribizel <[email protected]>
ginkgo-project · Jul 7, 2023 · a01d0ab · a01d0ab
1 parent a037db5
commit a01d0ab
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/test/base/kernel_launch_generic.cpp b/test/base/kernel_launch_generic.cpp
@@ -338,16 +338,15 @@ void run1d_reduction(std::shared_ptr<gko::EXEC_TYPE> exec)
 
     {
         SCOPED_TRACE("Size 0");
-        run_reduction(int64{1}, size_type{0});
+        run_reduction(int64{0}, size_type{0});
 
-        ASSERT_EQ(exec->copy_val_to_host(output.get_const_data()), int64{1});
+        ASSERT_EQ(exec->copy_val_to_host(output.get_const_data()), int64{0});
     }
 
     {
         SCOPED_TRACE("Size 100000");
         run_reduction(int64{0}, size_type{100000});
 
-        // 2 * sum i=0...99999 (i+1)
         ASSERT_EQ(exec->copy_val_to_host(output.get_const_data()),
                   int64{10000100000});
     }
@@ -394,23 +393,20 @@ void run2d_reduction(std::shared_ptr<gko::EXEC_TYPE> exec)
         SCOPED_TRACE("Dim 0x0");
         run_reduction(int64{0}, gko::dim<2>{0, 0});
 
-        // 4 * sum i=0...999 sum j=0...99 of (i+1)*(j+1)
         ASSERT_EQ(exec->copy_val_to_host(output.get_const_data()), int64{0});
     }
 
     {
         SCOPED_TRACE("Dim 0x10");
         run_reduction(int64{0}, gko::dim<2>{0, 10});
 
-        // 4 * sum i=0...999 sum j=0...99 of (i+1)*(j+1)
         ASSERT_EQ(exec->copy_val_to_host(output.get_const_data()), int64{0});
     }
 
     {
         SCOPED_TRACE("Dim 10x0");
         run_reduction(int64{0}, gko::dim<2>{10, 0});
 
-        // 4 * sum i=0...999 sum j=0...99 of (i+1)*(j+1)
         ASSERT_EQ(exec->copy_val_to_host(output.get_const_data()), int64{0});
     }