Add development container #1267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
the
reg:helper-scripts
yhmtsai
reviewed
Mar 9, 2023
dev_tools/container/Dockerfile
Outdated
|
|
||
| RUN (echo "deb http://apt.llvm.org/jammy/ llvm-toolchain-jammy-15 main" > /etc/apt/sources.list.d/llvm15.list) && \ | ||
| (curl https://apt.llvm.org/llvm-snapshot.gpg.key > /etc/apt/trusted.gpg.d/apt.llvm.org.asc) && apt-get update && \ | ||
| apt-get install -y --no-install-recommends clang-15 clang-tools-15 clang-15-doc clangd-15 clang-tidy-15 clang-format-15 \ |
There was a problem hiding this comment.
should it use format 14 because we use clang-format-14 as our standard in repo
There was a problem hiding this comment.
I think we could install just clang-format-14 and use 15 for the rest, I would like to profit from the latest clang features
dev_tools/container/packages.yaml
Outdated
| @@ -0,0 +1,63 @@ | |||
| packages: | |||
There was a problem hiding this comment.
the packages listed here are installed from the apt, right?
There was a problem hiding this comment.
yes, they are not detectable by spack (yet), so I need to specify their location manually
- remove SYCL-specific headers from general builds - disable failing tests for rocFFT - disable DPC++ distributed tests
We cannot include nvcc in the spack environment because we need to avoid collisions in the `thrust` include dir. But we can make CMake find the CUDA toolkit that way.
MarcelKoch
reviewed
Jul 3, 2023
Comment on lines
-127
to
+128
| lsum += Kokkos::Experimental::abs( | ||
| (v_u(i) - correct_u(xi)) / | ||
| Kokkos::Experimental::abs(correct_u(xi))); | ||
| lsum += Kokkos::abs((v_u(i) - correct_u(xi)) / | ||
| Kokkos::abs(correct_u(xi))); |
There was a problem hiding this comment.
I think we should then require Kokkos >= 3.7
|
can you change the target branch to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dockerfile that can be used to build all of Ginkgo, including a few development tools. My long-term goal is to keep an updated version of this container with up-to-date prebuilt Ginkgo around and update it with every
developmerge to allow people to quickly start working on a new branch without having to rebuild everything every time.See https://hub.docker.com/repositories/ginkgodev with
unifiedandbasecontainers containing the full image or just the APT packages