Ogl rebase 1.5.0 #1273

greole · 2023-02-09T20:44:53Z

This PR just updates the internal ogl branch with current WIP from other non merged branches

Depends on:

- move implementation into .cpp - documentation Co-authored-by: Tobias Ribizel <[email protected]>

Co-authored-by: Marcel Koch <[email protected]>

In the old behavior, the storage size for the submatrix can go out-of-bounds. This can appear for submatrices of submatrices because the correction term (ie the starting column) is not correct wrt to the base matrix.

This PR enables Gmres for our distributed matrices and vectors. It also adds create_with_type_of to Vector, and create_with_type_of(..., gko::dim<2>, gko::dim<2>, stride) to Dense so that both Vector and Dense have the same interface.

Co-authored-by: Cordell Bloor <[email protected]> Co-authored-by: Renjith Ravindran <[email protected]>

Add missing thrust header to partition Related PR: #1214

This adds a simple sequential symbolic LU factorization to the factorization interface. Related PR: #1210

This PR fixes an issue observed on some systems where binding the thread creating the executor to the closest PU that hwloc detected created a significant performance drop. Now the binding is removed, as it was decided that Ginkgo should probably not handle the binding, but it should done by either the application through OpenMPI or other hardware level libraries. Related PR: #1230

Co-authored-by: Tobias Ribizel <[email protected]>

This PR deletes gitlab status update because gitlab support it. It still keeps the running/skipping full pipeline check with the same status name Related PR: #1231

This PR fixes the generic spmv algorithm enum name, which is deprecated in cuda 11.2.1 and removed in cuda 12 Related PR: #1235

This PR updates git-cmake-format to include the latest fix for setting the git hooks directory. This also fixes the directory for the dummy hook. Related PR: #1226

Co-authored-by: Pratik Nayak <[email protected]>

Co-authored-by: Terry Cojean <[email protected]>

Co-authored-by: Gregor Olenik <[email protected]>

pick it onto repartitioner branch

…e-1.5.0

This reverts commit adeeabd.

This reverts commit 88024e0.

NOTE pick this on top of ogl-repartitioner branch

ginkgo-bot · 2023-02-23T09:39:57Z

Error: The following files need to be formatted:

common/unified/distributed/partition_helpers_kernels.cpp
core/distributed/partition.cpp
core/distributed/partition_helpers.cpp
core/distributed/repartition.cpp
core/distributed/vector.cpp
cuda/distributed/partition_helpers_kernels.cu
include/ginkgo/core/base/mpi.hpp
include/ginkgo/core/distributed/matrix.hpp
include/ginkgo/core/distributed/partition_helpers.hpp
omp/distributed/partition_helpers_kernels.cpp
reference/distributed/partition_helpers_kernels.cpp
reference/test/distributed/partition_helpers_kernels.cpp
test/distributed/partition_helper_kernels.cpp
test/mpi/distributed/vector.cpp

You can find a formatting patch under Artifacts here or run format! if you have write access to Ginkgo

…nto ogl-rebase-1.5.0

MarcelKoch and others added 30 commits December 6, 2022 10:01

reduces krylov_dim in tests

02d6a99

review updates:

eb7978c

- move implementation into .cpp - documentation Co-authored-by: Tobias Ribizel <[email protected]>

Format files

aed264f

Co-authored-by: Marcel Koch <[email protected]>

enable mpi solver test with 1 process

e0c93fb

fixes dense submatrix array size

6c79665

In the old behavior, the storage size for the submatrix can go out-of-bounds. This can appear for submatrices of submatrices because the correction term (ie the starting column) is not correct wrt to the base matrix.

Merge distributed gmres

eb15f9f

This PR enables Gmres for our distributed matrices and vectors. It also adds create_with_type_of to Vector, and create_with_type_of(..., gko::dim<2>, gko::dim<2>, stride) to Dense so that both Vector and Dense have the same interface.

Add missing thrust header to partition

bfef90f

Co-authored-by: Cordell Bloor <[email protected]> Co-authored-by: Renjith Ravindran <[email protected]>

Merge Add missing thrust header to partition

e6df568

Add missing thrust header to partition Related PR: #1214

add simple symbolic LU factorization

249996c

add device tests for unsymmetric LU

8f138a0

review updates

06b13fc

Merge sequential symbolic LU factorization

bd49a7b

This adds a simple sequential symbolic LU factorization to the factorization interface. Related PR: #1210

Remove GPU to PU binding for HIP and CUDA

5c0330e

Add itercount param for dist example

635fec4

Remove binding to closest PU altogether.

b50f2d5

Fix doc for additional param

1cfd83c

delete gitlab status update because gitlab support

f1c18d6

change the trigger pipeline

8a1e52d

Co-authored-by: Tobias Ribizel <[email protected]>

Merge delete gitlab status update because gitlab support it

e4665af

This PR deletes gitlab status update because gitlab support it. It still keeps the running/skipping full pipeline check with the same status name Related PR: #1231

the 11.x deprecated generic alg is removed in 12

ae41b43

Merge Fix the generic spmv algorithm for Cuda 12

65a4600

This PR fixes the generic spmv algorithm enum name, which is deprecated in cuda 11.2.1 and removed in cuda 12 Related PR: #1235

temporary enable newest gcf changes

fb4e72d

install dummy hook into ginkgo git directory

bd872d0

uses latest commit in git-cmake-format master branch

01e9486

Merge Updates git-cmake-format

33147b2

This PR updates git-cmake-format to include the latest fix for setting the git hooks directory. This also fixes the directory for the dummy hook. Related PR: #1226

add simple check on wiki

1fc5d14

Co-authored-by: Pratik Nayak <[email protected]>

fix the issue from action

c825433

use the script to get latest label from rest api

83f93f2

update doc, add link to wiki page, update format

12f04c5

Co-authored-by: Terry Cojean <[email protected]>

greole and others added 8 commits February 16, 2023 17:21

Add vec mean tests

afdbded

Format files

767bd46

Co-authored-by: Gregor Olenik <[email protected]>

Add reference implementation of compute_mean

5a596b2

Add a preliminary version of compute_mean

839500a

Fixup

b405090

Fixup test for complex values

32de753

Add vec mean implementation

af1301f

Fix rebase artifacts

6b44107

greole force-pushed the ogl-rebase-1.5.0 branch from 21b1d5e to 6b44107 Compare February 16, 2023 17:09

greole added 8 commits February 16, 2023 19:45

Fixup

533520e

Fixup move onto ogl-dist-mat-updates

365200f

use stable sort for partition sorting

de02742

Reuse all_to_all_pattern

adeeabd

pick it onto repartitioner branch

Merge remote-tracking branch 'origin/ogl-rebase-1.5.0' into ogl-rebas…

d768b63

…e-1.5.0

Revert "Reuse all_to_all_pattern"

d212e89

This reverts commit adeeabd.

Switch from std::vector to gko::array

88024e0

Revert "Switch from std::vector to gko::array"

fb996aa

This reverts commit 88024e0.

greole force-pushed the ogl-rebase-1.5.0 branch 2 times, most recently from a538dee to de02742 Compare February 23, 2023 07:58

WIP reuse communication pattern and sorting

21fc6cb

NOTE pick this on top of ogl-repartitioner branch

greole and others added 8 commits February 23, 2023 14:37

Fixup

c294ff3

Fixup

35768f0

fixup

8549b01

Merge branch 'ogl-rebase-1.5.0' of github.com:ginkgo-project/ginkgo i…

aa46bc7

…nto ogl-rebase-1.5.0

Merge branch 'ogl-rebase-1.5.0-fix' into ogl-rebase-1.5.0

2ca961a

cherry-pick oneapi6 fix

c1448f1

add try_run replacement patch

7800c4f

fixup patch

4292ffd

greole closed this Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ogl rebase 1.5.0 #1273

Ogl rebase 1.5.0 #1273

greole commented Feb 9, 2023 •

edited

Loading

ginkgo-bot commented Feb 23, 2023

Ogl rebase 1.5.0 #1273

Ogl rebase 1.5.0 #1273

Conversation

greole commented Feb 9, 2023 • edited Loading

ginkgo-bot commented Feb 23, 2023

greole commented Feb 9, 2023 •

edited

Loading