Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve benchmark setup #1323

Merged
merged 13 commits into from
Aug 30, 2023
Merged

Improve benchmark setup #1323

merged 13 commits into from
Aug 30, 2023

Commits on Aug 28, 2023

  1. nlohmann_json refactor

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b469ad6 View commit details
    Browse the repository at this point in the history

  2. add distributed tests again 

    This reverts commit 0dab762.
Additionally replaces the JSON test case output by their description
    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c1cee35 View commit details
    Browse the repository at this point in the history

  3. handle JSON and non-JSON test output separately

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ca3fccf View commit details
    Browse the repository at this point in the history

  4. benchmark reads on device_matrix_data

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d27b507 View commit details
    Browse the repository at this point in the history

  5. remove allocations from output 

    they are sometimes implementation-dependent
for libstdc++ types
    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e3af029 View commit details
    Browse the repository at this point in the history

  6. update matrix outputs

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9cd278c View commit details
    Browse the repository at this point in the history

  7. review updates 

    - rename 'determinize' -> 'sanitize'
- use empty struct for empty benchmark state
- use version tag instead of commit ID
- use std::endl where appropriate

Co-authored-by: Marcel Koch <[email protected]>
    @upsj @MarcelKoch
    upsj and MarcelKoch committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8adf765 View commit details
    Browse the repository at this point in the history

  8. annotate repetitions

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8d52ec8 View commit details
    Browse the repository at this point in the history

  9. update test output

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e2f2996 View commit details
    Browse the repository at this point in the history

  10. update documentation

    @upsj
    upsj committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    49ffd96 View commit details
    Browse the repository at this point in the history

  11. review updates 

    - remove unnecessary stdin in tests
- simplify validate_config
- consistently use pointer members instead of reference members

Co-authored-by: Marcel Koch <[email protected]>
    @upsj @MarcelKoch
    upsj and MarcelKoch committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a725d3c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. review updates 

    - don't install nlohmann-json
- simplify code
- improve config description formatting

Co-authored-by: Yuhsiang M. Tsai <[email protected]>
    @upsj @yhmtsai
    upsj and yhmtsai committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7b482dc View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. keep trailing EOL

    @upsj
    upsj committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    fe3789c View commit details
    Browse the repository at this point in the history