Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug reported by sonarcloud #1355

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix bug reported by sonarcloud #1355

merged 1 commit into from
Jul 3, 2023

Conversation

MarcelKoch
Copy link
Member

This PR should fix the single bug reported by sonarcloud: https://sonarcloud.io/project/issues?open=AYTucKfs8qk247btl14g&id=ginkgo-project_ginkgo, by disabling the ambiguous range constructor.

@MarcelKoch MarcelKoch self-assigned this Jun 30, 2023
@ginkgo-bot ginkgo-bot added the mod:core This is related to the core module. label Jun 30, 2023
@MarcelKoch MarcelKoch added 1:ST:ready-for-review This PR is ready for review 1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:run-full-test labels Jun 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5036395) 91.25% compared to head (47fa61b) 91.26%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1355   +/-   ##
========================================
  Coverage    91.25%   91.26%           
========================================
  Files          598      598           
  Lines        50699    50699           
========================================
+ Hits         46263    46268    +5     
+ Misses        4436     4431    -5     
Impacted Files Coverage Δ
include/ginkgo/core/base/range.hpp 95.51% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MarcelKoch MarcelKoch merged commit 5929937 into develop Jul 3, 2023
14 checks passed
@MarcelKoch MarcelKoch deleted the sonarcloud-fix branch July 3, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-for-review This PR is ready for review 1:ST:run-full-test mod:core This is related to the core module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants