Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing $ in CI_COMMIT_TAG #1393

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix missing $ in CI_COMMIT_TAG #1393

merged 1 commit into from
Aug 18, 2023

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Aug 18, 2023

This PR fix the missing $ in CI_COMMIT_TAG.
It was not captured by gitlab before.
the old one does not create a pipeline now https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/pipelines/972242549
include:rule if invalid expression syntax

@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Aug 18, 2023
@yhmtsai yhmtsai requested a review from a team August 18, 2023 12:32
@yhmtsai yhmtsai self-assigned this Aug 18, 2023
@ginkgo-bot ginkgo-bot added the reg:ci-cd This is related to the continuous integration system. label Aug 18, 2023
@yhmtsai yhmtsai merged commit 0851e8a into develop Aug 18, 2023
13 checks passed
@yhmtsai yhmtsai deleted the fix_pipeline branch August 18, 2023 12:47
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@tcojean tcojean tcojean approved these changes

Assignees

@yhmtsai yhmtsai

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yhmtsai @upsj @tcojean @ginkgo-bot