WIP: Tag jobs by required runner capabilities #1394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
MarcelKoch
force-pushed
the
ctest-resources
branch
from
c796297
to
fbec06b
Compare
otherwise, the default stream is used in some places, e.g. initializing cublas. But it is not clear with which device the default stream is associated. Thus, this now sets the device id correctly for the new stream
this is necessary, since some test call the kernels directly and not through the executor. In this case, the setting of the device id by the executor is skipped, which leads to these kernel not run.
Co-authored-by: Tobias Ribizel <[email protected]>
Co-authored-by: Tobias Ribizel <[email protected]>
- remove test file - small documentation - more verbose device id output Co-authored-by: Tobias Ribizel <[email protected]>
Co-authored-by: Marcel Koch <[email protected]>
Co-authored-by: Tobias Ribizel <[email protected]>
- cmake documentation - take omp num thread into account for resource file Co-authored-by: Yu-Hsiang M. Tsai <[email protected]>
upsj
force-pushed
the
gitlab_capability_tags
branch
from
cd00a74
to
286b028
Compare
upsj
force-pushed
the
gitlab_capability_tags
branch
from
286b028
to
2b26e7e
Compare
upsj
force-pushed
the
ctest-resources
branch
2 times, most recently
from
0799a12
to
4c2defa
Compare
Merged
|
I'll redo this properly in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we use tags like
amdciandhorekato determine where to run our tests. It would be more scalable if instead we just listed which capabilities a runner has in its tags (nvidia-gpu,nvidia-multi-gpu,amd-gpu,amd-multi-gpuandcpucome to mind). That way, we can move to other platforms much more seamlessly if necessary.Also, it seems that none of our AMD tests running on
nla1? We should change that.The branch is a bit messy since it is based on a rebased
ctest-resourcesbranch, only the last commit is interesting.This PR is not final yet, I want to use it to collect necessary changes to enable running on apptainer FTP/Horeka.