Use quoted arguments in cmake if #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhmtsai
approved these changes
Nov 15, 2023
MarcelKoch
force-pushed
the
fix-compiler-check
branch
from
34a2c8a
to
d6d56c0
Compare
pratikvn
approved these changes
Nov 15, 2023
upsj
approved these changes
Nov 15, 2023
Co-authored-by: Yu-Hsiang M. Tsai <[email protected]>
upsj
force-pushed
the
fix-compiler-check
branch
from
d6d56c0
to
1ce455e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds quotes around the arguments to the if-clauses in the ginkgo compiler check. Otherwise, if one of the arguments is empty, it leads to cmake errors.