Remove old variable in CMake gko_rename_cache

[upsj]

I wanted to propose this change to get rid of warning messages on my long-standing repositories, be creative in thinking of potential negative side-effects this might have!

This removes the old variable from cache instead of leaving it around, which leads to the error message only being shown once instead of continuously. Removing variables from cache requires modifying the CMakeCache.txt, which isn't something we need to ask of them.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0775637) 91.33% compared to head (9aec535) 89.30%.
Report is 15 commits behind head on develop.

❗ Current head 9aec535 differs from pull request most recent head 78454bb. Consider uploading reports for the commit 78454bb to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1471      +/-   ##
===========================================
- Coverage    91.33%   89.30%   -2.04%     
===========================================
  Files          688      688              
  Lines        56098    56336     +238     
===========================================
- Hits         51239    50310     -929     
- Misses        4859     6026    +1167     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yhmtsai]

As we discussed in #1350 , I do not have strong opinions on either one.
I do not get why it introduces the issue. It only throws the warning and should not block any operation. user can unset the variable from cmake command by -U<parameter>

[upsj]

Showing the warning once is fine, but since we can easily fix this, showing it repeatedly is noise. We should keep the amount of noise small to highlight more important warning messages. If a user only had the old variable in their CMakeCache.txt, they won't care we changed it. If they always use -DGINKGO_BUILD_DPCPP=ON in their CMake invocation, they will get the warning every time, highlighting the issue for them.

[yhmtsai]

I can not comment on whether user do not care or not on some hidden changes.

[upsj]

As a developer, I definitely care 😄 I think deprecation warnings make sense if somebody is actively doing something deprecated, but if it's just a variable they still have in their CMakeCache.txt, we can fix it for them.

[ginkgo-bot]

Error: PR already merged!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here