-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dim constructor explicit #1474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Might this be considered interface breaking? I wouldn't hold it up, just curious.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This is technically interface breaking, but as we have previously broken interface for wrong behaviour, it should be okay, I think.
@MarcelKoch @pratikvn Yes, that was in #650 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs 77.8% Coverage The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
To avoid things like
dim<2>{1, 2} == 3
working accidentally, we need to make the single-parameter constructorexplicit
.