use pre-commit clang-format for format_header #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
the
reg:helper-scripts
MarcelKoch
approved these changes
Nov 28, 2023
pratikvn
approved these changes
Nov 28, 2023
yhmtsai
added
1:ST:ready-to-merge
yhmtsai
force-pushed
the
fix_clangformat_formatheader
branch
10 times, most recently
from
d3b1419
to
be2b564
Compare
Co-authored-by: Tobias Ribizel <[email protected]>
yhmtsai
force-pushed
the
fix_clangformat_formatheader
branch
from
be2b564
to
d1a6b70
Compare
upsj
approved these changes
Nov 28, 2023
MarcelKoch
reviewed
Nov 28, 2023
| @@ -22,6 +22,7 @@ jobs: | |||
| name: check-format | |||
| if: github.event.issue.pull_request != '' && github.event.comment.body == 'check-format!' && (github.event.comment.author_association == 'COLLABORATOR' || github.event.comment.author_association == 'MEMBER' || github.event.comment.author_association == 'OWNER') | |||
| uses: ./.github/workflows/check-formatting.yml | |||
| secrets: inherit | |||
There was a problem hiding this comment.
I thought this would need to be in check-formatting.yml. And where is the token set to the bot token?
There was a problem hiding this comment.
It never gets to check-formatting.yml, because we don't inherit the secrets to it
There was a problem hiding this comment.
Oh, ok, secrets: inherit allows check-formatting.yml to access the secrets.
There was a problem hiding this comment.
The related information:
https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow
they do not pass the secret to reusable workflow by default.
MarcelKoch
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the pre-commit clang-format for format_header for consistent clang-format version and avoid no clang-format issue.
Also, fix the
types_or