Change write_raw default to sparse output format #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
MarcelKoch
approved these changes
Jan 17, 2024
yhmtsai
approved these changes
Jan 18, 2024
| layout_type layout = layout_type::array); | ||
| layout_type layout = layout_type::coordinate); |
There was a problem hiding this comment.
I think we use array as default in the beginning to keep the same behavior as the old interface:
void write_raw(std::ostream& os, const matrix_data<ValueType, IndexType>& data);
but it should not be public interface break with this change
upsj
added
1:ST:ready-to-merge
upsj
force-pushed
the
write_raw_sparse
branch
from
198fda8
to
a879808
Compare
This leads to a much better worst-case storage size (roughly 3x overhead instead of linear overhead) at the cost of slightly worse best case storage requirement. Since this is only a utility function, it shouldn't matter much.
upsj
force-pushed
the
write_raw_sparse
branch
from
a879808
to
6a9cddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leads to a much better worst-case storage size (roughly 3x overhead instead of linear overhead) at the cost of slightly worse best case storage requirement.
Since this is only a utility function, it shouldn't matter much.