Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run examples as part of the test suite #1558

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Run examples as part of the test suite #1558

merged 5 commits into from
Mar 18, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented Feb 27, 2024

Similar to #1341, this moves the script we used previously for comparing the example output with its reference into our regular test suite. To enable platform portability, I replaced the Linux-specific commands by a Python script

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Feb 27, 2024
@upsj upsj requested a review from a team February 27, 2024 16:53
@upsj upsj self-assigned this Feb 27, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:example This is related to the examples. labels Feb 27, 2024
examples/compare-output.py Show resolved Hide resolved
examples/compare-output.py Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
Copy link
Collaborator

@fritzgoebel fritzgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Mar 11, 2024
@upsj upsj merged commit 0ca8bca into develop Mar 18, 2024
10 of 15 checks passed
@upsj upsj deleted the example_tests branch March 18, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. reg:build This is related to the build system. reg:ci-cd This is related to the continuous integration system. reg:example This is related to the examples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants