Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use destdir for .pc install #1597

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Use destdir for .pc install #1597

merged 2 commits into from
Apr 17, 2024

Conversation

MarcelKoch
Copy link
Member

This PR allows us to use the DESTDIR environment variable when installing the pkg config file. All other parts of the install step already handle that variable correctly. Also uses the path of the installed config file to deduce the pkg prefix.

@MarcelKoch MarcelKoch self-assigned this Apr 17, 2024
@MarcelKoch MarcelKoch added this to the Ginkgo 1.8.0 milestone Apr 17, 2024
@ginkgo-bot ginkgo-bot added the reg:build This is related to the build system. label Apr 17, 2024
@MarcelKoch MarcelKoch linked an issue Apr 17, 2024 that may be closed by this pull request
@MarcelKoch MarcelKoch requested a review from a team April 17, 2024 11:25
@MarcelKoch MarcelKoch merged commit b22b859 into develop Apr 17, 2024
9 of 15 checks passed
@MarcelKoch MarcelKoch deleted the use-destdir-for-.pc-install branch April 17, 2024 11:36
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test reg:build This is related to the build system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake install step with DESTDIR does not work
6 participants