Reduce the DistributedBase interface #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
mod:core
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
613231d
to
daf690d
Compare
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
2 times, most recently
from
ca9cb11
to
bfeca24
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
40f74db
to
fda0fc9
Compare
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
bfeca24
to
643d886
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
fda0fc9
to
51ff6f9
Compare
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
2 times, most recently
from
74f81ff
to
afb7bcf
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
51ff6f9
to
37aef87
Compare
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
afb7bcf
to
dd32707
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
f2cd744
to
2072219
Compare
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
2 times, most recently
from
0c725a9
to
e6543ec
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
20e3d96
to
2812123
Compare
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
e6543ec
to
280a66e
Compare
yhmtsai
reviewed
May 12, 2024
core/base/dispatch_helper.hpp
Outdated
| * | ||
| * @return the result of f invoked with obj cast to the first matching type | ||
| */ | ||
| template <template <class> class K, typename... Types, typename T, |
There was a problem hiding this comment.
Suggested change
| template <template <class> class K, typename... Types, typename T, | |
| template <template <class> class Base, typename... Types, typename T, |
also the documentation needs to be adjusted. I have changed some documentations here, you may need to rebase and keep them similar.
With that, I think the following function can be deleted, right?
There was a problem hiding this comment.
Which following function do you mean? This at l.221 or at l.252?
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
2 times, most recently
from
1ae79b6
to
d35432b
Compare
MarcelKoch
changed the base branch from
read-distributed-with-index-map
to
develop
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
d35432b
to
b240d9b
Compare
|
@yhmtsai I've unified the |
yhmtsai
approved these changes
May 13, 2024
core/base/dispatch_helper.hpp
Outdated
| * @tparam Func the function type that is invoked if the object can be | ||
| * converted to std::shared_ptr<K> | ||
| * converted to pointer of const Base<K> |
There was a problem hiding this comment.
Suggested change
| * converted to pointer of const Base<K> | |
| * converted to pointer of Base<K> |
The const depends on the given type now, right?
core/base/dispatch_helper.hpp
Outdated
Comment on lines
240
to
241
| * @tparam T the type of input object waiting converted, has to be either | ||
| * unique_ptr or shared_ptr |
There was a problem hiding this comment.
It can only be shared_ptr because dynamic_pointer_cast only allow shared_ptr and the ownership issue.
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
b240d9b
to
e19e53a
Compare
pratikvn
approved these changes
May 13, 2024
MarcelKoch
added
1:ST:ready-to-merge
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
e19e53a
to
2b5553d
Compare
Co-authored-by: Yu-Hsiang M. Tsai <[email protected]>
MarcelKoch
force-pushed
the
reduce-dist-base-interface
branch
from
2b5553d
to
456f509
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the interface changes to the
DistributedBaseinterface. It removes the virtual functionget_local_size. The only place where this was used was in the multigrid solver. There it has been replaced by using therundispatch with every possible distributed Matrix type.It also makes
runeasier to use by automatically deducing the const qualifier.Note: although this is based on #1544, it can be rebased on develop and merged before.