Add json config #1607
Merged
Add json config #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
|
MarcelKoch
approved these changes
May 10, 2024
Co-authored-by: Tobias Ribizel <[email protected]>
yhmtsai
added
1:ST:ready-to-merge
MarcelKoch
added a commit
that referenced
this pull request
May 16, 2024
This merge fixes the json config test for MSCV. To avoid setting the lib path in msvc, gko makes all test works in the library path (dll location). I changed the working directory to access testing file in #1607. However, it can not find the dll path now. follow the `matrices/config.hpp.in` to pass the file path Related PR: #1610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds header only json config which follows the same setup as kokkos extension.
Because it is quite simple one, do we just compile it into extension library?
For example, we only provide
parse_json_fileor sstream way to user.The json library will not need to export to user and we/users do not need to install it.