Add executor get_description function
#1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:testing
MarcelKoch
approved these changes
Jun 28, 2024
| @@ -1427,6 +1432,8 @@ class ReferenceExecutor : public OmpExecutor { | |||
| return {this, 0}; | |||
| } | |||
|
|
|||
| std::string get_description() const override { return "ReferenceExecutor"; } | |||
There was a problem hiding this comment.
I guess at some point we should also move the reference exec implementations into a .cpp file.
pratikvn
approved these changes
Jun 28, 2024
upsj
force-pushed
the
executor_description
branch
from
11a9491
to
ade3329
Compare
upsj
added
1:ST:ready-to-merge
upsj
force-pushed
the
executor_description
branch
from
b8a9398
to
ed5623d
Compare
upsj
force-pushed
the
executor_description
branch
from
ed5623d
to
bf09bd2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function that prints a textual representation of the device used by an executor, and uses it in tests/benchmarks