-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and updates, bump third party libraries #1619
Changes from all commits
e519de1
4f1cd22
b5a12e1
bb006d8
8ea34a6
6aab89d
567bd82
cb12a33
4655295
06868cb
08818f6
fd5cc1a
43189ba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,13 +91,21 @@ function(ginkgo_add_test test_name test_target_name) | |
endif() | ||
set_target_properties(${test_target_name} PROPERTIES OUTPUT_NAME ${test_binary_name}) | ||
if (add_test_MPI_SIZE) | ||
add_test(NAME ${REL_BINARY_DIR}/${test_binary_name} | ||
COMMAND | ||
${MPIEXEC_EXECUTABLE} | ||
${MPIEXEC_NUMPROC_FLAG} | ||
${add_test_MPI_SIZE} | ||
"$<TARGET_FILE:${test_target_name}>" | ||
WORKING_DIRECTORY "$<TARGET_FILE_DIR:ginkgo>") | ||
if (add_test_MPI_SIZE LESS_EQUAL MPIEXEC_MAX_NUMPROCS) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it necessary? MPIEXEC_MAX_NUMPROCS is the number of processor on the host. but mpi should be able run more than it, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See this job for example https://github.com/ginkgo-project/ginkgo/actions/runs/9288144680/job/25558834125#step:6:2170 There are other ways to fix this, such as allowing oversubscription, but this could make these already slow tests take a really long time, which I would vote against. |
||
add_test(NAME ${REL_BINARY_DIR}/${test_binary_name} | ||
COMMAND | ||
${MPIEXEC_EXECUTABLE} | ||
${MPIEXEC_NUMPROC_FLAG} | ||
${add_test_MPI_SIZE} | ||
"$<TARGET_FILE:${test_target_name}>" | ||
WORKING_DIRECTORY "$<TARGET_FILE_DIR:ginkgo>") | ||
else() | ||
message( | ||
WARNING | ||
"Disabling test: ${test_target_name}. Only ${MPIEXEC_MAX_NUMPROCS} " | ||
"MPI processes available but ${add_test_MPI_SIZE} processes required." | ||
) | ||
endif() | ||
else() | ||
add_test(NAME ${REL_BINARY_DIR}/${test_binary_name} | ||
COMMAND ${test_target_name} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a more permanent fix would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but I've seen other pipelines fail with the same problem, e.g. https://github.com/Jimver/cuda-toolkit/actions/runs/8767123552/job/24060026380#step:11:101 so there is something fishy going on with Github's Windows setup in general.