Remove deprecated shared memory config #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikvn
added
the
type:batched-functionality
ginkgo-bot
added
mod:cuda
pratikvn
force-pushed
the
fix-shared-config
branch
from
bfd95ea
to
13a724a
Compare
MarcelKoch
approved these changes
Jun 28, 2024
pratikvn
added
1:ST:no-changelog-entry
upsj
approved these changes
Jun 28, 2024
pratikvn
force-pushed
the
fix-shared-config
branch
from
13a724a
to
3377b4f
Compare
pratikvn
added
1:ST:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the shared memory config guard functionality which enabled device level bank size configuration based on the value type. This functionality has been deprecated from after Kepler devices, and is hence no longer necessary. Additionally, the function is also being deprecated from after CUDA 12.4
Reported by @upsj.