Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify factorization kernels #1647

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Unify factorization kernels #1647

merged 5 commits into from
Jul 15, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented Jul 12, 2024

This unifies the ParILUT/ICT and ILU(0)/IC(0) kernels and the unimplemented index_set kernels.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Jul 12, 2024
@upsj upsj self-assigned this Jul 12, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. type:factorization This is related to the Factorizations labels Jul 12, 2024
@upsj upsj added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Jul 13, 2024
@upsj upsj requested a review from a team July 13, 2024 09:28
pratikvn
pratikvn approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 15, 2024
@upsj upsj merged commit 6ea8133 into develop Jul 15, 2024
9 of 14 checks passed
@upsj upsj deleted the unify_factorization branch July 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

Assignees

@upsj upsj

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:build This is related to the build system. type:factorization This is related to the Factorizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upsj @pratikvn @MarcelKoch @ginkgo-bot