Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Jacobi #1648

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Unify Jacobi #1648

merged 1 commit into from
Jul 15, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented Jul 13, 2024 •
edited
Loading

This unifies Jacobi kernels into common/cuda_hip. Most of the changes are related to the CMake setup for parallel builds of the different block sizes

@upsj upsj added 1:ST:ready-for-review This PR is ready for review 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Jul 13, 2024
@upsj upsj requested a review from a team July 13, 2024 09:27
@upsj upsj self-assigned this Jul 13, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:cuda This is related to the CUDA module. type:preconditioner This is related to the preconditioners mod:hip This is related to the HIP module. labels Jul 13, 2024
@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 15, 2024
Base automatically changed from unify_factorization to develop July 15, 2024 15:52
@upsj upsj merged commit 5adaebc into develop Jul 15, 2024
10 of 14 checks passed
@upsj upsj deleted the unify_jacobi branch July 15, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratikvn pratikvn pratikvn approved these changes

@MarcelKoch MarcelKoch MarcelKoch approved these changes

Assignees

@upsj upsj

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:build This is related to the build system. type:preconditioner This is related to the preconditioners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upsj @pratikvn @MarcelKoch @ginkgo-bot