Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Csr #1649

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Unify Csr #1649

merged 4 commits into from
Jul 16, 2024

Conversation

upsj
Copy link
Member

@upsj upsj commented Jul 14, 2024

This unifies the csr_kernels files and removes all switches we had for older CUDA 10.x versions.

@upsj upsj added the 1:ST:ready-for-review This PR is ready for review label Jul 14, 2024
@upsj upsj requested a review from a team July 14, 2024 20:44
@upsj upsj self-assigned this Jul 14, 2024
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. mod:cuda This is related to the CUDA module. type:matrix-format This is related to the Matrix formats mod:hip This is related to the HIP module. labels Jul 14, 2024
@upsj upsj added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Jul 15, 2024
MarcelKoch
MarcelKoch approved these changes Jul 15, 2024
View reviewed changes
cuda/CMakeLists.txt Show resolved Hide resolved
pratikvn
pratikvn approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@pratikvn pratikvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits.

common/cuda_hip/matrix/csr_kernels.template.cpp Show resolved Hide resolved
@upsj upsj added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Jul 15, 2024
Base automatically changed from unify_factorization to develop July 15, 2024 15:52
@upsj upsj changed the base branch from develop to unify_jacobi July 15, 2024 15:56
Base automatically changed from unify_jacobi to develop July 15, 2024 20:24
@upsj upsj merged commit e34e43f into develop Jul 16, 2024
10 of 14 checks passed
@upsj upsj deleted the unify_csr branch July 16, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelKoch MarcelKoch MarcelKoch approved these changes

@pratikvn pratikvn pratikvn approved these changes

Assignees

@upsj upsj

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. mod:cuda This is related to the CUDA module. mod:hip This is related to the HIP module. reg:build This is related to the build system. type:matrix-format This is related to the Matrix formats
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@upsj @pratikvn @MarcelKoch @ginkgo-bot