-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the race condition of bicgstab #1676
Conversation
2657f8c
to
17672ea
Compare
Would it be possible to construct a test where this fails more reliably? E.g. many rhs, few rows |
17672ea
to
72c0247
Compare
It needs more rows such that some have updated the stop_status, but the rest does not read the stop_status yet after the cache value is updated. |
@upsj @MarcelKoch please feel free to take a look at the test. I will wait for the test failed on our CI and then push the fix back again. If everything works correctly, I will merge this pr |
The failed tests are in https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/pipelines/1446060008 |
ea82909
to
f57bb12
Compare
This pr fixes the race condition of bicgstab.
Originally, we put the finalize and update together.
That means that some threads might get the finalized value from the other thread and the thread will not update the value.
We need to separate them to ensure update the stop_status after update values.
It should solve #1563